SolidBench / SolidBench.js

A benchmark for Solid to simulate vaults with social network data.
MIT License
10 stars 11 forks source link

Update CSS to version 6, update ESLint configs and add Node 18 to CI #8

Closed surilindur closed 1 year ago

surilindur commented 1 year ago

The main goal here was to bump the Community Solid Server dependency to version 6, because it was stuck on 5 and 6 has been out for a while now. The latest version of the CSS also allows .meta files with FixedContentTypeMapper, which makes it possible to add triples to containers themselves for benchmarking purposes. I have adjusted the server configuration in templates to work with the new CSS version.

The other changes in this PR that I wanted to have feedback on (making it a draft) are the following:

Any feedback is welcome. I can also remove changes if some of them seem dubious. :slightly_smiling_face:

surilindur commented 1 year ago

Yes, the server works still. I ran the generate and serve commands locally after the changes and both worked. Generating the validation things did not work, but it also did not work before the changes (it produces a JSON-like error about something query-related).

Thank you for the feedback!

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 6035257917


Totals Coverage Status
Change from base Build 5529156034: 0.0%
Covered Lines: 116
Relevant Lines: 116

💛 - Coveralls
surilindur commented 1 year ago

Is it enough to change the Node version requirement in readme to 15? According to the MDN, replaceAll has been in Node since version 15.

rubensworks commented 1 year ago

Let's put 16. Uneven Node versions are considered unstable.

surilindur commented 1 year ago

I have changed the Node requirement to 16. Are there any other things that should preferably be changed before merging?

rubensworks commented 1 year ago

I think Node was it indeed! Is this PR ready for another review? (you can click re-request review on top of this page)

rubensworks commented 1 year ago

Thanks @surilindur! Do you need a new release of this?

surilindur commented 1 year ago

Yes, but not immediately. If there will be a new release at some point within the next month or two that should be enough. It will take me a while to get the code ready for benchmarking.

rubensworks commented 1 year ago

Ok, just ping me as soon as you need it. (unlikely that a new release will show up otherwise)