Closed surilindur closed 1 year ago
Yes, the server works still. I ran the generate and serve commands locally after the changes and both worked. Generating the validation things did not work, but it also did not work before the changes (it produces a JSON-like error about something query-related).
Thank you for the feedback!
Totals | |
---|---|
Change from base Build 5529156034: | 0.0% |
Covered Lines: | 116 |
Relevant Lines: | 116 |
Is it enough to change the Node version requirement in readme to 15? According to the MDN, replaceAll
has been in Node since version 15.
Let's put 16. Uneven Node versions are considered unstable.
I have changed the Node requirement to 16. Are there any other things that should preferably be changed before merging?
I think Node was it indeed! Is this PR ready for another review? (you can click re-request review on top of this page)
Thanks @surilindur! Do you need a new release of this?
Yes, but not immediately. If there will be a new release at some point within the next month or two that should be enough. It will take me a while to get the code ready for benchmarking.
Ok, just ping me as soon as you need it. (unlikely that a new release will show up otherwise)
The main goal here was to bump the Community Solid Server dependency to version 6, because it was stuck on 5 and 6 has been out for a while now. The latest version of the CSS also allows
.meta
files withFixedContentTypeMapper
, which makes it possible to add triples to containers themselves for benchmarking purposes. I have adjusted the server configuration in templates to work with the new CSS version.The other changes in this PR that I wanted to have feedback on (making it a draft) are the following:
@rubensworks/eslint-config
to version 2, and removing the dependencies from here that are provided by that package already. Three rules had to be disabled in.eslintrc.js
after this, but otherwise it seemed to just work.rimraf
to use an actual version rather thanlatest
, because the tag was causing some warnings about unpack paths and something being skipped with Yarn version 1.--ignore-engines
to avoid 'package not compatible with Node version' errors--frozen-lockfile
to make sure the CI installs exactly what is in the lockfile.Any feedback is welcome. I can also remove changes if some of them seem dubious. :slightly_smiling_face: