SolidCharity / LightBuildServer

LightBuildServer for building rpm and deb packages and running CI scripts, using linux containers
BSD 3-Clause "New" or "Revised" License
11 stars 1 forks source link

no emails are sent anymore when a build does not succeed #107

Closed tpokorra closed 4 years ago

tpokorra commented 9 years ago
  File "../lib/Logger.py", line 93, in email
    server = smtplib.SMTP_SSL(host=self.emailserver, port=self.emailport, timeout=10)
  File "/usr/lib/python3.2/smtplib.py", line 853, in __init__
    SMTP.__init__(self, host, port, local_hostname, timeout)
  File "/usr/lib/python3.2/smtplib.py", line 260, in __init__
    (code, msg) = self.connect(host, port)
  File "/usr/lib/python3.2/smtplib.py", line 321, in connect
    (code, msg) = self.getreply()
  File "/usr/lib/python3.2/smtplib.py", line 367, in getreply
    line = self.file.readline(_MAXLINE + 1)
TypeError: readline() takes exactly 1 positional argument (2 given)
tpokorra commented 9 years ago

see also http://bugs.python.org/msg227927

tpokorra commented 9 years ago

small test script:

import sys
import os
sys.path.append(os.path.join(os.path.dirname(__file__), '../lib'))
import Logger

log = Logger.Logger()
log.print("test")
log.email("test@pokorra.de", "timo@pokorra.de", "test", "http://www.pokorra.de")
tpokorra commented 9 years ago

yes new smtplib version in python3.2 for Ubuntu 12.04: http://changelogs.ubuntu.com/changelogs/pool/main/p/python3.2/python3.2_3.2.3-0ubuntu3.7/changelog

tpokorra commented 4 years ago

this was fixed a long time ago