search

SolidCode / SolidPython

A python frontend for solid modelling that compiles to OpenSCAD
1.1k stars 172 forks source link

Cleanup tests #121

Closed Cabalist closed 4 years ago

Cabalist commented 4 years ago

Similar to previous PR. Focuses on removing import *

Cabalist commented 4 years ago

Friendly bump on this one since some other PRs got merged.

etjones commented 4 years ago

Sorry, hadn't noticed this one. However... there's some change to tabular data formatting in the tests that I need to think over a bit. I know Pep 8 is not in favor of spacing in code, but I sometimes am. Let me revisit this one tomorrow.

Cabalist commented 4 years ago

No rush and understandable.

Cabalist commented 4 years ago

This seems to have caused a test failure. I'm investigating now

etjones commented 4 years ago

Me too.

On Oct 15, 2019, at 4:32 PM, Ryan Jarvis notifications@github.com wrote:

This seems to have caused a test failure. I'm investigating now

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/SolidCode/SolidPython/pull/121?email_source=notifications&email_token=AAEWGLJQLY2Z4I6GBUI3CD3QOYZHJA5CNFSM4JAIKFIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBKJJVY#issuecomment-542414039, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEWGLIBAIIF46TVJUWTUQ3QOYZHJANCNFSM4JAIKFIA.