search

SolidCode / SolidPython

A python frontend for solid modelling that compiles to OpenSCAD
1.13k stars 175 forks source link

Move all the basic openscad objects into a new file #59

Closed eric-wieser closed 7 years ago

eric-wieser commented 7 years ago

This almost halves the size of the main file. Note that a circular import is necessary, since the base class references the subclasses.

I've added review comments to all the interesting bits of the diff, since its pretty large

eric-wieser commented 7 years ago

Wow, that was fast. Not waiting for CI builds any more?

etjones commented 7 years ago

TBH, I just hooked up the CI system and I don't know its ins and outs. The easiest way I knew to run all the tests was to merge the request on GH, see if everything passed, and roll back/ correct if I saw failures. If there's a more direct way to run tests on a PR, I'd love to hear about it (that's what I was just searching for)

eric-wieser commented 7 years ago

At the very least, it's possible to add pull requests as a remote, so that you can merge locally rather than on github. Some googling required.

I know that travis and appveyor can be set up to run on every pull request