SolidCode / SolidPython

A python frontend for solid modelling that compiles to OpenSCAD
1.11k stars 173 forks source link

Fix for disappearing holes, #73 #80

Closed etjones closed 7 years ago

etjones commented 7 years ago

@scifuentes pointed out a bug in how holes work in #73, but I think I found the source of the problem. I'd already taken into account that holes shouldn't be able to grow smaller by subtracting one from another, but the substitution that required (difference & intersection => union) wasn't being universally applied. Moved that big comment and the substitutions to the very end of _render_hole_children()