search

SolidCode / SolidPython

A python frontend for solid modelling that compiles to OpenSCAD
1.11k stars 173 forks source link

Add "angle" parameter to rotate_extrude() #87

Closed justbuchanan closed 6 years ago

justbuchanan commented 6 years ago

The angle parameter is present in openscad versions after 2016.xx. See https://en.wikibooks.org/wiki/OpenSCAD_User_Manual/2D_to_3D_Extrusion#Rotate_Extrude.

Note: I added the new parameter as the last argument to the function for backwards-compatibility reasons, but maybe it would make more sense to put it before the segments param. Thoughts?

etjones commented 6 years ago

In fact, the best order is probably angle, segments, convexity. In most use cases, you don't care about or need the convexity, but you really do need the angle, and might want to specify segments. Looks good though; LMK if you want to swap those around, and I'll merge

Cheers!

justbuchanan commented 6 years ago

Sounds great! I just reordered them.

etjones commented 6 years ago

Sweet. I just stuck convexity at the end; it's an ugly tail of OpenSCAD that hangs out lots of places but only effects certain situations.

justbuchanan commented 6 years ago

Sounds good. I misread your first comment, but that makes more sense.

Cheers!