search

SolidGeek / VescUart

An Arduino library for interfacing with the VESC over UART
GNU General Public License v3.0
177 stars 92 forks source link

Change type of port for setSerialPort to Stream #16

Closed felurx closed 4 years ago

felurx commented 4 years ago

This allows devs to use any kind of Stream, for example SoftwareSerial, to connect to the VESC. Since that works just fine, it's not necessary to limit it to just HardwareSerial. Note: I don't know if there are any scenarios where someone would want to use anything except for a Serial port, but maybe there is some weird case where it'd make sense to bridge the communication between Arduino and VESC via some other communication protocol, so I went with Stream instead of Serial.

(This is my first time doing a pull request, so please tell me about anything I'm doing wrong. Thanks!)

felurx commented 4 years ago

...I just realized this is a duplicate of #3.