search

SolidHal / PrawnOS

Libre Mainline Kernel and Debian for arm laptops
https://www.PrawnOS.com
GNU General Public License v2.0
114 stars 29 forks source link

initial shellcheck tests #268

Closed austin987 closed 2 years ago

austin987 commented 3 years ago

I started on this a while back, but got sidetracked (and wanted to fix outstanding issues first).

However, since https://github.com/SolidHal/PrawnOS/commit/0bd5575b0b84bcf469cd0b94351c10f1a0a459f9 broke install for me, and would easily have been caught by shellcheck, I revisited it.

This is an initial pass. It currently ignores SC2068 (unquoted variables), and style issues in favor of only flagging error level issues.

To get that level of checking, however, I had to fix some outstanding issues, first ;).

@SolidHal

austin987 commented 3 years ago

Marking WIP while I look closer at something.

austin987 commented 3 years ago

Removing WIP, the issue I was seeing was unrelated to this.

This can go in.

SolidHal commented 2 years ago

fixed up the conflicts, will merge when checks pass

SolidHal commented 2 years ago

Merged this in 05746fcbb092715d48fc1cc9af4963341eaac8dd