SolidLabResearch / Bashlib

A Node.JS and CLI interface for Solid
https://solidlabresearch.github.io/Bashlib/
17 stars 6 forks source link

Fixed failing npm build on Windows machines #14

Closed Denperidge closed 2 years ago

Denperidge commented 2 years ago

OS: Windows 10 CLI: Git Bash Node version: 16.15.1, most recent LTS at the time of writing

Building bashlib would give errors when deleting, and then not run typescript. The error was code ELIFECYCLE, errno 1.

After trying to do the regular solution (clearing node_modules & cache, reinstalling node & npm...), I've found that modifying the npm build command to not throw errors on rm (rm -rf instead of rm -r), and using the more commonly used && instead of ; were a fix for the issue.

Normally ";" should indeed run the next command, even on error, so this might be a Windows exclusive issue? But more testing would be required for that.

Dexagod commented 2 years ago

Hi,

Thanks a lot for the fix! I'll include the fixes in the next version (or I'll merge this after I push the next version).

mielvds commented 2 years ago

Changes were merged via c257fc7