SolidLabResearch / generic-data-viewer-react-admin

MIT License
0 stars 1 forks source link

When editing an existing, correct custom query, if the new query version is erroneous, the previous result stays on screen #137

Open mvanbrab opened 2 months ago

mvanbrab commented 2 months ago

Example SPARQL query used in the correct custom query:

SELECT ?s ?p ?o WHERE {
  ?s ?p ?o
}

Example erroneous SPARQL query used in the update (mind the ?o2):

SELECT ?s ?p ?o2 WHERE {
  ?s ?p ?o
}

The updated result view shows an error at the bottom indeed, but the previous result table is still visible:

image

EmilioTR commented 1 month ago

I did not find an immediate cause for this issue. However, I have a solution in sight that will enhance the robustness of the query editor. We should implement a validation check when submitting a new or edited query to prevent submission if the query is faulty.

mvanbrab commented 1 month ago

The SPARQL query validation check is requested in #143. Let's not use it to avoid the current issue. We can use the current observation to understand why the displayed result table is out of sync, something that also happens randomly in other circumstances, where we see an old result that subsequently is updated with a new result.