Open mvanbrab opened 8 months ago
Looks good to me, I'd just add all explicit mappings and their meaning under https://github.com/SolidLabResearch/generic-data-viewer-react-admin?tab=readme-ov-file#adding-variable-type
And add a link to the MR that adds _purl to custom code and add that MR link to the readme, so future developers know how to add a more type hints
At the moment, there is already a representationProvider component CustomUrlField, activated by appending the type hint
_url
to a query variable name.Some queries however (for example
SELECT ?s ?p ?o
) may return values that are either literals or URI's (in the example: ?o).Suggestion: implement a new type hint
_purl
(possible URL) to cover such cases.