added option to log in with idp or webid

SolidLabResearch / generic-data-viewer

Generic query-based data viewer

MIT License

0 stars 0 forks source link

added option to log in with idp or webid #52

Closed AronBuzogany closed 1 year ago

AronBuzogany commented 1 year ago

This PR fixes #49

A user can now enter either the url to its idp's login endpoint or his webid
Not 2 seperate input fields, button to switch, keeping things simple and in one place
there is an open issue #51 which prevents us to use a future term (SOLID.oidsIssuer) when querying for the oidc issuer behind the webID

pheyvaer commented 1 year ago

What do you mean with

use a future term (SOLID.oidsIssuer) when querying for the oidc issuer behind the webID

AronBuzogany commented 1 year ago

What do you mean with

use a future term (SOLID.oidsIssuer) when querying for the oidc issuer behind the webID

I meant to say "future safe term", as it would be maintained without us having to look at it in case it updates.

pheyvaer commented 1 year ago

No, that is not an issue you have to deal with. The whole point of RDF, Semantic Web, and Solid is that people/developers try to minimize these changes.

AronBuzogany commented 1 year ago

No, that is not an issue you have to deal with. The whole point of RDF, Semantic Web, and Solid is that people/developers try to minimize these changes.

I agree it's not necessary, but I thought It'd be nicer. It works perfectly without it.