search

SolidLabResearch / generic-data-viewer

Generic query-based data viewer
MIT License
0 stars 0 forks source link

Fix #20 #75

Closed AronBuzogany closed 1 year ago

AronBuzogany commented 1 year ago

Thanks to a response on the issue opened in the Comunica repo, issue #20 is resolved

pheyvaer commented 1 year ago

I can't test this because of https://github.com/SolidLabResearch/generic-data-viewer/issues/76

AronBuzogany commented 1 year ago

I can't test this because of https://github.com/SolidLabResearch/generic-data-viewer/issues/76

I have tested it by replacing the fetch function with 

...
fetch: () => {throw new Error("fail")}
...

After refreshing a failed query, it fails again.

pheyvaer commented 1 year ago

I can't test this because of #76

I have tested it by replacing the fetch function with

...
fetch: () => {throw new Error("fail")}
...

After refreshing a failed query, it fails again.

For development sure, but from my side I only test the code as it is. Thus, #76 has to be fixed first before I look into this PR.

AronBuzogany commented 1 year ago

As of #78 this now works and all tests succeed.