SolidLabResearch / solid-todo-app-react

Solid ToDo application implemented using React
https://solidlabresearch.github.io/solid-todo-app-react/
0 stars 0 forks source link

npm install does not work #24

Closed rubensworks closed 1 year ago

rubensworks commented 1 year ago

When following the steps in the readme for installing the app (npm install), it fails with the following error:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: @react-navigation/native@6.0.13
npm ERR! Found: react@18.2.0
npm ERR! node_modules/react
npm ERR!   react@"^18.2.0" from the root project
npm ERR!   peer react@">16.13.0 || ^17.0.0 || ^18.0.0" from @inrupt/solid-ui-react@2.8.0
npm ERR!   node_modules/@inrupt/solid-ui-react
npm ERR!     @inrupt/solid-ui-react@"^2.8.0" from the root project
npm ERR!   8 more (@react-navigation/core, @react-navigation/native, ...)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer react-native@"*" from @react-navigation/native@6.0.13
npm ERR! node_modules/@react-navigation/native
npm ERR!   @react-navigation/native@"^6.0.13" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: react@18.1.0
npm ERR! node_modules/react
npm ERR!   peer react@"18.1.0" from react-native@0.70.2
npm ERR!   node_modules/react-native
npm ERR!     peer react-native@"*" from @react-navigation/native@6.0.13
npm ERR!     node_modules/@react-navigation/native
npm ERR!       @react-navigation/native@"^6.0.13" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /Users/rtaelman/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/rtaelman/.npm/_logs/2022-10-05T06_46_13_630Z-debug-0.log

This can be fixed by installing using npm install --legacy-peer-deps.

We should either make installation work via npm install, or we should update our README.

surilindur commented 1 year ago

This has been fixed now, it seemed to have been caused by a React dependency that was not actually used anywhere, and removing it and regenerating package lock fixed it.