longChat/shortChat

[bourgeoa]

Following up of the matrix discussion https://matrix.to/#/!wAfwwonbRnRLYejFOR:gitter.im/$aMThy_4XD203KsjPzMEV8uX8uUqbAL7N5iuM90uYZcY?via=gitter.im&via=matrix.org&via=chat.semantic.works

There are actually 2 chats pane in SolidOS :

• import { longChatPane, shortChatPane } from 'chat-pane'
• longChatPane is the general chat pane used as a standalone chat This is the most elaborate chat and also expected to be the backup of matrix chats
• shortChatPane is used as a simple comments pane embeded in meeting pane and tracker pane, but can also be used alone

See the copy screen :

To simplify we may consider having only one chat pane (longChatPane) and a comments pane (shortChatPane).

A comments pane icon

• should not appear on the new pane creation (green + button). To do that : remove the mintNew function (https://github.com/SolidOS/chat-pane/blob/7fb256d269224f410f354da5211f14f7276a1e02/src/shortChatPane.js#L66)
• should appear in tools icons creation (tools + button) (https://github.com/SolidOS/meeting-pane/blob/122f0e0587272b137a32a3bb5484b65df1bbf23a/src/meetingPane.js#L776).
• and be used on rendering (https://github.com/SolidOS/solid-panes/src/registerPanes.js)

This should have no impact in existing pods either on shortChat, or on tracker be it in meeting-pane or in issue-pane.

Further code clarification could be to create a separate comments-pane by removing it from the chat-pane. But the mintClass: ns.meeting('Chat') should be kept to not add a regression

[SharonStrats]

great investigation. This makes a lot of sense to me. I do think we should rename it in chat-pane, we can prevent regression by also leaving the export for shortChatPane.

[timbl]

shortPane.mintNew:Please don't just remove any functionality, deporocate it. I'm happy for even an alert() to be called but in general it should keep working for something like 6 months, incase we have missed a place where it is used.