search

SolidOS / solid-panes

A set of core solid-compatible apps based on solid-ui
MIT License
101 stars 44 forks source link

'View ...'s files' link go only to same dashboard-pane not displaying any new information. #294

Open bourgeoa opened 3 years ago

bourgeoa commented 3 years ago

@timbl @SharonStrats This is the consequence of commit https://github.com/solid/solid-panes/commit/4cff4db8b319c3bf9bafe3ae76cd5c336742d9a0

This is not a good idea because now you go to the same dashboard-pane and never display any content. The only way to get information is to click on folder icon.

Going to /public/ displays at least the /public/ in folder-pane. This seems a user regression.

A solution could be first to reverse the commit and may be next to list in homepage.ts the root folder content as folder-pane as can be seen in https://files.gitter.im/54d55a83db8155e6700f8b7a/41mY/pod-root.png proposal from @jeff-zucker

But I don't know how to add the code to call and display a pane area containing a root folder-pane in https://github.com/solid/solid-panes/blob/main/src/dashboard/homepage.ts

timbl commented 3 years ago

To display a specific pane it is like

const pane = context.session.paneRegistry.byName('folder')
  or
const pane = panes.byName('folder')

const paneDiv = pane.render(subject, context, options)