search

SolidOS / solid-ui

User Interface widgets and utilities for Solid
https://solidos.github.io/solid-ui/dist/solid-ui.js
MIT License
148 stars 41 forks source link

Migrated create module to TypeScript #169

Closed megoth closed 3 years ago

megoth commented 4 years ago

Gave migrating create module to TypeScript a go.

Builds upon the work in https://github.com/solid/solid-ui/pull/168

michielbdejong commented 4 years ago

@megoth what is the status of this PR now?

megoth commented 4 years ago

@megoth what is the status of this PR now?

I don't know for sure, as I haven't worked on this in a long time. But skimming through the code, it seems to be a "simple" conversion (e.g. not added or removed logic, simply converted the code to TypeScript). But I do not know how this works with the rest of mashlib, as I haven't worked on the codebase recently.

angelo-v commented 3 years ago

This PR goes against a branch that is 636 commits behind master. The changes seem to be part of https://github.com/solid/solid-ui/pull/171