search

SolidOS / solid-ui

User Interface widgets and utilities for Solid
https://solidos.github.io/solid-ui/dist/solid-ui.js
MIT License
148 stars 41 forks source link

Find out intended behaviour to shortNameForFolder #196

Open michielbdejong opened 4 years ago

michielbdejong commented 4 years ago

shortNameForFolder returns 'example.com' for 'https://example.com/' and '/' for 'https://'. I'm not certain this is actually by design, it might be that the intended behaviour was that the domain root would already get labeled '/'. That would make more sense to me for a filebrowser.

michielbdejong commented 4 years ago

See https://github.com/solid/solid-ui/blob/master/test/unit/acl/acl-control.test.ts#L44-L65 (edited) for the current behaviour.

SharonStrats commented 4 years ago

I'm thinking things may have gotten moved around, the link above gives a 404 error.

michielbdejong commented 4 years ago

Edited the link, thanks.

megoth commented 4 years ago

You might want to double check this with @timbl if you're still uncertain about the intended behavior.

michielbdejong commented 4 years ago

@timbl do you know?