search

SolidOS / solid-ui

User Interface widgets and utilities for Solid
https://solidos.github.io/solid-ui/dist/solid-ui.js
MIT License
148 stars 41 forks source link

Add-agent-buttons adds third element when rendering the view for apps (only in tests) #236

Open megoth opened 4 years ago

megoth commented 4 years ago

When working on https://github.com/solid/solid-ui/pull/232 I had to fix a test that broke. It's the test When "Add App" button is clicked > bar is simplified that is affected. It expects two elements to remain after Add App button is clicked, but for some reason three elements remain after the action.

This only happens in the test, I have not been able to reproduce it "manually".

I've tried to understand why this happens, but have succumbed to let it be for now, as there are more urgent matters to tend to. But creating this issue to track it, to revisit it when I have time, or if others are more lucky than me.

jaxoncreed commented 3 years ago

Apparently this had something to do with the auth library. What it is exactly, I have no clue, but I'm currently updating it to the new auth library here (https://github.com/solid/solid-ui/pull/420) and we're back to 2 elements. So, this can be closed once #420 (nice) is merged.

timea-solid commented 2 years ago

I am working on moving authn from solid-ui to solid-logic and now the test returns again the correct number: 2 elements but before this we had to put it to 3 again. Very nondeterministic...