search

SolidOS / solid-ui

User Interface widgets and utilities for Solid
https://solidos.github.io/solid-ui/dist/solid-ui.js
MIT License
148 stars 41 forks source link

Global Trusted Dialog appears in middle of local Web App auth ACL control #346

Open timbl opened 4 years ago

timbl commented 4 years ago

I’m looking at the ACL control place for adding access by an Origin to the local folder. When I click on the green plus then the app icons, I get expect to get the chance to add just one Origin to the access list. But I get my global trusted apps files "Manage your trusted applications”. Underneath it is the line I need to fill in with the domain I am going to trust for this folder. but it is very confusing to have the global apps list between the two.

image

timbl commented 4 years ago

image

Also there seems to be a "You have 15 selected webapps" message after the origin input field.

timbl commented 4 years ago

I guess the intent of the code at https://github.com/solid/solid-ui/blob/master/src/acl/add-agent-buttons.ts#L153 may have been to use the set of trusted apps a picker, returning a single one of the apps in the user's global trusted list. That makes sense, in that the user can put an app there, not put any global trust in it, and then where they need to give local access, pick it from that list. But in fact it is a global context-free panel.