SolidOS / solid-ui

User Interface widgets and utilities for Solid
https://solidos.github.io/solid-ui/dist/solid-ui.js
MIT License
147 stars 39 forks source link

Cannot add new friend/WebID in Friends pane with Safari #380

Open janschill opened 3 years ago

janschill commented 3 years ago

I cannot add a new friend/WebID to my friends list in the Friends pane. The attached video shows how to reproduce the issue.

Safari: Version 14.0.3 (16610.4.3.1.4) NSS: solid-server/5.6.4

Dropped URI list (2): https://michielbdejong.solidcommunity.net/profile/card#me
TypeError: e.forEach is not a function. (In 'e.forEach((function(e){var r=(0,a.sym)(e);c.log("Dropped on attachemnt "+e),n.push((0,a.st)(t,x,r,m))}))', 'e.forEach' is undefined)

Error is thrown here: https://github.com/search?q=org%3Asolid+Dropped+on+attachemnt&type=code

https://user-images.githubusercontent.com/26876570/109012447-50fdd200-76b2-11eb-8895-2427652aac57.mov

janschill commented 3 years ago

I tried with another session and it seems to work now. I cannot say what changed. Please close or leave open – your decision.

janschill commented 3 years ago

I've tried again. In Safari I get the issue described above. In Chrome it works as expected.

angelo-v commented 3 years ago

Does it depend on whether the friend list is initially empty?

janschill commented 3 years ago

I don't think so. My friend list is not empty and if I try to add you using Safari I get the same error as above:

image
angelo-v commented 3 years ago

might be related to https://stackoverflow.com/questions/50299337/foreach-on-ios-safari-wont-work

angelo-v commented 3 years ago

Hmm, the forEach at this location should be fine. Do you have other issues with drag and drop in SolidOS on Safari or only on the friend list?

janschill commented 3 years ago

Same thing on the “Edit your profile” page.

https://user-images.githubusercontent.com/26876570/110004387-acb20600-7d17-11eb-90e1-81ed7bd519f0.mov

timea-solid commented 3 years ago

I could reproduce the problem locally on Safari and it shows image