SolidOS / solid-ui

User Interface widgets and utilities for Solid
https://solidos.github.io/solid-ui/dist/solid-ui.js
MIT License
148 stars 41 forks source link

Attempting to set new access control on resource results in "Error: Drop fails to drop appropriate thing!" #419

Open AJamesPhillips opened 3 years ago

AJamesPhillips commented 3 years ago

Bug

I see the error: Error: Error: Drop fails to drop appropriate thing! https://solid.github.io/solid-ui/src/icons/noun_98053.svg when I try to change the access control for a resource by adding "Add Everyone" to "Viewers.

Steps to recreate

  1. I created a directory in my root solidcommunity.net pod called getting-started
  2. I visited https://.solidcommunity.net/getting-started/
  3. I clicked on the padlock and then on the first green plus icon
  4. I drag and dropped the "Add Everyone" icon to the "Viewers" row.
  5. The error was shown.

Pasted_Image_04_08_2021__15_38

Additional context

Once, somehow, I managed to "Add Everyone" to the Viewers list but I was not able to recreate that.

bourgeoa commented 3 years ago

I can't reproduce your problem. Can you give more context : OS, browser, mouse/touchscreen

AJamesPhillips commented 3 years ago

OS: MacOS 11.1 Chrome & Brave Mouse and built in touchpad

Looks like it might be a CORS error?

Console log output:

dragenter event dropEffect: none
dragenter event dropEffect 2: link
Drop event. dropEffect: none
Drop event. types: text/uri-list, text/html
Dropped text/uri-list: https://solid.github.io/solid-ui/src/icons/noun_98053.svg
Dropped URI list (2): https://solid.github.io/solid-ui/src/icons/noun_98053.svg
    drop object type includes: http://www.w3.org/ns/iana/media-types/image/svg+xml#Resource
    drop object type includes: http://www.w3.org/2007/ont/link#Document
    drop object type includes: http://purl.org/dc/terms/Image
    Triage fails for https://solid.github.io/solid-ui/src/icons/noun_98053.svg
   Not obvious: looking up dropped thing <https://solid.github.io/solid-ui/src/icons/noun_98053.svg>
Access to XMLHttpRequest at 'https://solid.github.io/solid-ui/src/icons/noun_98053.svg' from origin 'https://ajp.solidcommunity.net' has been blocked by CORS policy: The value of the 'Access-Control-Allow-Origin' header in the response must not be the wildcard '*' when the request's credentials mode is 'include'. The credentials mode of requests initiated by the XMLHttpRequest is controlled by the withCredentials attribute.
Fetcher: <https://solid.github.io/solid-ui/src/icons/noun_98053.svg> Non-HTTP fetch exception: TypeError: Network request failed
Fetcher: CORS: RETRYING with NO CREDENTIALS for <https://solid.github.io/solid-ui/src/icons/noun_98053.svg>
GET https://solid.github.io/solid-ui/src/icons/noun_98053.svg net::ERR_FAILED
    drop object type includes: http://www.w3.org/ns/iana/media-types/image/svg+xml#Resource
    drop object type includes: http://www.w3.org/2007/ont/link#Document
    drop object type includes: http://purl.org/dc/terms/Image
    Triage fails for https://solid.github.io/solid-ui/src/icons/noun_98053.svg
    Error: Drop fails to drop appropriate thing! https://solid.github.io/solid-ui/src/icons/noun_98053.svg

Screenshot 2021-08-04 at 23 33 24

Network tab:

Screenshot 2021-08-04 at 23 39 06

The directory's script (?)

@prefix : <#>.
@prefix dct: <http://purl.org/dc/terms/>.
@prefix ldp: <http://www.w3.org/ns/ldp#>.
@prefix stat: <http://www.w3.org/ns/posix/stat#>.
@prefix xsd: <http://www.w3.org/2001/XMLSchema#>.
@prefix get: <>.
@prefix re: <readingList/>.

get:
    a ldp:BasicContainer, ldp:Container;
    dct:modified "2021-08-04T14:37:05Z"^^xsd:dateTime;
    ldp:contains re:;
    stat:mtime 1628087825.876;
    stat:size 4096.
re:
    a ldp:BasicContainer, ldp:Container, ldp:Resource;
    dct:modified "2021-08-04T14:09:57Z"^^xsd:dateTime;
    stat:mtime 1628086197.596;
    stat:size 4096.

Video of recreating error:

https://user-images.githubusercontent.com/526509/128264336-b1d35b6b-a2fd-4580-89fd-56ed0fda9234.mp4

bourgeoa commented 3 years ago

I was able to recreate the error when moving the Eveybody icon. The same error arise with Authenticated Agent There is no error when you click on the icon and do not move it.

AJamesPhillips commented 3 years ago

Thank you. Yes I can confirm that if I click on the Everybody icon it places it into "Viewers" from which I can drag it to other permission levels. Thank you. I will leave this issue open as you have added the Bug label.