search

SolidOS / solid-ui

User Interface widgets and utilities for Solid
https://solidos.github.io/solid-ui/dist/solid-ui.js
MIT License
146 stars 39 forks source link

Create a dedicated lib for forms #510

Open timea-solid opened 1 year ago

timea-solid commented 1 year ago

Separate the forms code out of solid-ui into its own lib. This would allow faster loading of it and easier reuse. See discussion: https://gitter.im/solid/solidos?at=62d9064b76cd751a2f55cee9

Just for the record: Jeff had ideas to improve the form with this https://github.com/jeff-zucker/solid-ui-components/issues/15

timea-solid commented 1 year ago

Another feature idea: https://github.com/SolidOS/solid-ui/issues/509

jeff-zucker commented 1 year ago

I generally like this idea but here's what I wonder : in almost all use cases one needs to be authenticated to use a form so if forms are split off then most users will need to also import the inrupt libraries. Are we saving them anything by having the forms separate or would they just need to put most of solid-ui back to use authenticated forms? It may be good for logical reasons but I'm not sure it will solve the size/deployment issues.

timea-solid commented 1 year ago

solid-forms, like solid-ui would be using solid-logic. (for now this is the only dependency I see necessary)

jeff-zucker commented 1 year ago

So other than forms and solid-logic and rdflib and the inrupt library, what does that leave in solid-ui itself and is what it leaves a large byte-size saver compared to all those other heavy-lifters which would be in solid-forms? (I'm not arguing against doing this, just suggesting that optimization of size may not be one of its benefits)

timea-solid commented 1 year ago

Solid-ui has a lot of extra code which solid-forms would not need. But to be honest I do not know how how much less in size it will be. One other advantage: solid-forms will be easier to read and code in, easier to find your way around, hopefully