search

SolidOS / solid-ui

User Interface widgets and utilities for Solid
https://solidos.github.io/solid-ui/dist/solid-ui.js
MIT License
146 stars 39 forks source link

Removing Jss from style #540

Closed timea-solid closed 1 year ago

timea-solid commented 1 year ago

This is work for https://github.com/SolidOS/solid-ui/issues/533 Please check code. This was not tested beyond storybook.

bourgeoa commented 1 year ago

@timea-solid This is what I get running watch on the full stack It seems the issues are only located in mashlib header

image

bourgeoa commented 1 year ago

@timea-solid style.headerUserMenu is used on L132 and L241 but do not exits in style. Is this correct ?

timea-solid commented 1 year ago

@timea-solid style.headerUserMenu is used on L132 and L241 but do not exits in style. Is this correct ?

@bourgeoa that is ok because the headerUserMenu was empty, had no defined style.

Please retest. I believe now it is pretty good :)

I will also wait to see about the menu gradient color change: https://matrix.to/#/!wAfwwonbRnRLYejFOR:gitter.im/$2eRLkn8qhHE-YeEOuqzihO29ENVReH_Qhkx3v19XL1U?via=gitter.im&via=matrix.org&via=chat.semantic.works

bourgeoa commented 1 year ago

@timea-solid I think you can merge. The only thing is that you will have to review that there are no issues with the chat-threads branch and make the necessary commits if needed.

timea-solid commented 1 year ago

@bourgeoa i checked and it is fine. Thanks for pointing out.