search

SolidOS / solidos

The operating system for Solid
https://solidos.solidcommunity.net/
MIT License
127 stars 19 forks source link

Unclear error message when adding non-group as group in sharing pane #121

Open renyuneyun opened 2 years ago

renyuneyun commented 2 years ago

I tried this (from the dashboard of mashlib) on both CSS (my own server) and NSS (solidcommunity.net), and this error exists in both cases.

This happens when I try to add something that is not a vcard:Group as a group in sharing pane (where https://ME/ is the URL to my user's pod):

Error: Error: Drop fails to drop appropriate thing! https://ME/friends#group

(or https://ME/friends, if pointing to the file.)

Steps to reproduce:

  1. Expand to a file or directory.
  2. Open the share pane.
  3. Click on "add" button (assuming the file/directory has its own ACL).
  4. Click on "group" (the second button).
  5. Type a URI to a resource, and the resource is not a vcard:Group. In my case, I tried both https://ME/friends#group and https://ME/friends; the friends file is a ttl file in Solid (accessible to everyone), containing :group a foaf:Group and some other relevant information.
  6. Click on "tick"/yes button.
  7. Error appears.
timbl commented 2 years ago

@renyuneyun It has to be a vcard:Group, not a foaf:Group. That's what the ACL system uses. Sorry this wasn't clear from the error message.

timbl commented 2 years ago

Given that you had already selected that you want to add a group, nothing else, then it should have been able to say 

Error: Failed to add group to access:  `https://ME/friends#group` is not a `vcard:Group`
renyuneyun commented 2 years ago

Thanks very much @timbl . That helps a lot. I got myself confused when trying that and switching between accounts.

I'll change the description of this issue to make the actual thing clear.