SolidOS / solidos

The operating system for Solid
https://solidos.solidcommunity.net/
MIT License
127 stars 19 forks source link

Slideshow accepts new files via a drag and drop but nothing happens #175

Open phochste opened 2 years ago

phochste commented 2 years ago

Browser: Vivaldi | 5.3.2679.68 (Stable channel) (x86_64)

Test server: https://hochstenbach.solidcommunity.net:8443

In the slideshow menu I can drop a new image file. I get a Javascript message that says "Are you sure you want drop this file here". When I click OK the image file gets opened in a new tab (with URL file:///Users/patrickhochstenbach/Desktop/Images/optimism.jpeg) but nothing changes on the pod.

I would expect:

bourgeoa commented 2 years ago

Can you be more precise with your problem. CSS or NSS which server ?

browser : chrome : I just uploaded on bourgeoa.solidcommunity.net/public/hochtenbach/ without any problem. (.jpg or .jpeg file - file deleted after without any problem)

TallTed commented 2 years ago

@phochste -- A screenshot will likely be helpful, with clear indication of where you're dropping the image file, as "drop zones" may vary, and if you are drop the file outside the "upload" drop zone, your experience may be as expected -- which may be because the drop zone is not be as intended. Along similar lines, your OS (name and version, which you did not provide, but it appears to be some version of macOS, based on the URL shown in the new Vivaldi tab) can matter as much as your browser (name and version, which you did provide).

phochste commented 2 years ago

I'm running Vivaldi on OSX Big Sur and I am testing the Solid NSS test server. I didn't notice the slideshow button before and tried to use it.

hochstenbach_solidcommunity_net_8443_-_Vivaldi-1

Apparently I can drag and drop an image file in this region and get a JavaScript alert message asking me to confirm that I want to upload. When I click 'OK' only a new tab gets opened with my local file. I was wondering why I get a dropzone there, and is that a feature?

2-_Vivaldi

timbl commented 2 years ago

What you are seeing I think is the default drop action of a web browser, to navigate to display the thing dropped. That message is to protect users from losing the state of their current web page. The "Cancel" is to protect the current tab by putting the dropped thing inn a new one. The "OK" lets the event handler drop though to one provided by the page or if none the bowser default.

In your case it looks like the slideshow pane doesn't have a handler, so you dropped though to the browser default, and you were lucky it opened in a tab and didn't overwrite the current tab.

I propose we should enhance the slide show pane so that it accepts dropped things. (And maybe suppresses the favicon but that is another issue.?)

josephguillaume commented 1 year ago

As a starting point, slideshow pane is in solid-panes: https://github.com/SolidOS/solid-panes/blob/main/src/slideshow/slideshowPane.js