search

SolidOS / solidos

The operating system for Solid
https://solidos.solidcommunity.net/
MIT License
127 stars 19 forks source link

Publish solid-auth-client and solid-client-authn versions #18

Closed RubenVerborgh closed 3 years ago

RubenVerborgh commented 3 years ago

@timbl suggested to publish a build of the solid-client-authn branch.

This could either be part of the same npm package, or could be published with a different tag on npm.

Or just as a build somewhere.

jaxoncreed commented 3 years ago

I'm sorry I don't understand what this is saying. Is solid-client-authn not already published? https://www.npmjs.com/package/@inrupt/solid-client-authn-browser

RubenVerborgh commented 3 years ago

Woops, lemme rewind 🙂 I’m looking for a solidos release that has solid-client-authn-browser as a dependency instead of solid-auth-client. I heard there was a branch for that, but not merged given the page refresh issue.

jaxoncreed commented 3 years ago

Ah yep. That's this here: https://github.com/solid/node-solid-server/pull/1488 (note that it's split between 4 repos)

However, it should also be noted that this is not merged in because it would mean the user is logged out whenever they refresh. This was unacceptable from the UX perspective. These changes are also behind master.

The plan is to update the changes to master and merge it in once solid-client-authn is fixed to maintain the session between refreshes.

RubenVerborgh commented 3 years ago

Exactly; so the purpose of this issue is to suggest releasing it anyway; not as a main release, but rather as a tagged release on npm, for the reason you mention.

jaxoncreed commented 3 years ago

Okay, I'll need to ask @emmettownsend about this. It would take extra work to get these ready for a full release. I am currently committed to the CSS IdP, so I'll see what he prioritizes.

angelo-v commented 3 years ago

I guess this is a requirement to run SolidOS on CSS?

jaxoncreed commented 3 years ago

@angelo-v that is correct.

@RubenVerborgh I just talked with @emmettownsend. The priority at the moment is the CSS IdP. Once that is at a preliminary stage, my focus can be shifted back to SolidOs work.

That would not prevent anyone from taking the work that I've done and trying to release it themselves, but be warned that these PRs have not been worked on in about a month and when I last pulled them down, there were some broken things due to changes that happened to other libraries since then.

RubenVerborgh commented 3 years ago

Thanks @jaxoncreed. For CSS, we mainly want to test, which we can do by using a mock auth module on the server. Databrowser users will have to await the release.