search

SolidOS / solidos

The operating system for Solid
https://solidos.solidcommunity.net/
MIT License
127 stars 19 forks source link

SolidOS should not silently fail when unable to retrieve WebID during granting permission #209

Open renyuneyun opened 4 months ago

renyuneyun commented 4 months ago

SolidOS/Mashlib has a tab for each resource/container to modify its sharing permissions / access control lists. It allows to grant permission to an individual WebID entered by the user. If everything goes normal, after entering WebID and clicking yes, the textbox and yes/no disappears, and an avatar corresponding to that WebID will appear as a "viewer". Then the user can drag-and-drop it to the appropriate location.

However, if the entered WebID cannot be retrieved, the textbox and yes/no disappears as well, but nothing further happens. This is very un-user-friendly...

Preferably, SolidOS should either:

  1. Alarm the user that something wrong happened when retrieving the WebID document; or
  2. Add the WebID as a viewer regardlessly; or
  3. A combination of the two above (e.g. alarm, and allow proceeding regardlessly).

I haven't tried similar things on other types, but maybe worth checking if they have similar issues?

melvincarvalho commented 2 months ago

Good feedback, I lean towards (2)—adding the WebID even if SolidOS can't connect.

The Pod might be down, or the client could have lost internet. In a local-first model, SolidOS should be able to function offline, like during a plane flight.

There's definitely scope to enhance the UX with warnings as well.