SolidOS / solidos

The operating system for Solid
https://solidos.solidcommunity.net/
MIT License
127 stars 19 forks source link

Handling goto links #70

Open jeff-zucker opened 3 years ago

jeff-zucker commented 3 years ago

Goto links (the grey circle to the right of resource names in the outline) will not behave as expected with the new auth flow. This shows up when logging in from the server root on NSS but also in ESS and CSS no matter where you login.

bourgeoa commented 3 years ago

@jeff-zucker What is the problem ? I don't have any problem with https://bourgeoa.solidcommunity.net:8443 nor with https://bourgeoa.solidcommunity.net:8443/browse.html I tried with 2 different webId's : https://bourgeoa.solidcommunity.net:8443/profile/card#me and https://solidweb.me/bourgeoa/profile/card#me

jeff-zucker commented 3 years ago

1) On NSS : Login to server-root, on your pod, click on the goto link of a private container. The opened page will show you as logged out but it will also show you private resources.

2) On ESS using browse.html : Clicking on any goto link jumps out of the databrowser. This may be the intended effect but is not what happens on NSS for containers and rdf resources which are shown in the databrowser. This could probably be solved by making the link include the full location.href ( https://browse.html?uri=otherLink) when called with a uri in the search params.

3) On CSS using the browse.html - all goto links including containers and rdf resources jump out of the databrowser and also lose login

jeff-zucker commented 3 years ago

I do not see any of these as critical. I would be fine with merging to main and dealing with these issues at a later date.

bourgeoa commented 3 years ago

The problem is that you are not logged out. You have the login button but you can edit your private file. @aveltens I'm wondering if it is the same problem already found with a missing credentials: true in a fetch

timbl commented 3 years ago

I propose that we replace a large number of places where there are links, including the goto icon link, with the same user experience:

or something like that.

jeff-zucker commented 3 years ago

I have been thinking of a larger revamp (probably for the future) which would do something like this, but for the whole interface. As we add things like these items and all of the needed things to manage files/folders, we are getting a very large number of actions. I would like to group them and have submenus in a standard place for each. Here's some thoughts:

Have action-category icons to be displayed where the current goto button is - i.e. visible before the user opens the resource. These would be instead of the current pane icons which are only visible on opening the resource.

Clicking on any of these main actions would open a submenu and a default view (first item on the submenu). The submenus would be :

jeff-zucker commented 3 years ago

In addition to providing grouped-functions this plan would reduce the clutter by having all user controls for a given resource in one place rather than having to wonder which container the green plus applies to or hunt for the edit/save/cancel buttons.

It would also reduce the number of clicks in most cases - one could open directly in edit mode rather than 1) open resource 2) if not on source pane, go to it 3) scroll down till you find the edit button (often off screen for me)