search

SolidOS / solidos

The operating system for Solid
https://solidos.solidcommunity.net/
MIT License
124 stars 18 forks source link

IDP Dropdown misbehaves in webapp #88

Open jeff-zucker opened 2 years ago

jeff-zucker commented 2 years ago

The IDP dropdown now grabs the current URL and offers it as a place to login. Great feature! However, in the webapp, it uses the URL of the place the web app is located, not the place the web app is visiting. See the "github.io" in my location bar and on the IDP list in the screenshot below.

We should always be aware that URLs may be in the form http://example.com/ or in the form http://example.com/?uri=http://otherplace.example.com/. I had code to check that in the IDP dropdown but it got removed when Jackson decided he didn't like trying to show the current page a an IDP option. I can put it back in next week when I return from the coast. alain3 .

jeff-zucker commented 2 years ago

Also, I (or someone else) should add the ability to submit the IDP dropdown with a carriage return.

TallTed commented 2 years ago

form http://exampl.com/ or in the form http://example.com/?uri=http://otherplace/.

I suggest those URIs be changed (including in the comment above) to http://example.com/ and http://example.com/?uri=http://example.org/ or similar -- i.e., always use example TLDs.

jeff-zucker commented 2 years ago

@TallTed you are, as always, correct. I much appreciate your attention to detail for documentation and code. Your comments on issues are another matter. One of the main functions of issues is to allow as wide a range as possible of contributors. Even if someone does not know the exact way to phrase something or is brainstorming and writes a quick thought, we as a community need to hear what people have to say. Seeing repeated comments of the type you make is very discouraging of new input to issues. I happen to know if it's pod or Pod and content-type when I meant media-type or I used ex.com instead of example.com so, you are always welcome to correct me in a private message. But I do not find it supports the goals of increasing inclusion in these discussions for you to repeatedly publicly commenting on issues to remark on technical details which have no bearing whatsoever on the content of the issue. I am sure that you believe that you are doing a good thing by helping people learn the correct phrasing. I agree this is an important goal and should be addressed in our documentation. But I also know for a fact that there are developers with lots to contribute who are afraid to raise issue because they believe (correctly if you're around) that they will be criticized unless they ask in exactly the right way. Again, for documentation and code, your corrections are essential, I am not suggesting you stop those. But I do ask you to consider whether the goal, of making this an inclusive community is met by you bringing up minor details of issue disscussions.

TallTed commented 2 years ago

@jeff-zucker -- Habitually using inaccurate and/or incorrect terms, where the accurate and/or correct term is known and could be used, is problematic in that it leads to the inaccurate and/or incorrect terms being treated as if they were accurate and/or correct, and interpretations of writings are then made based on the actual definitions of the inaccurate and/or incorrect terms, leading to incorrect PRs, revolving-door issues that recur with regularity, and other problems. I try to break that pattern as quickly as possible, in order to prevent such propagation, because I've dealt with the repercussions too often.

Regarding this particular instance, I think you've been around long enough to have seen a piece of software or documentation with a default or sample email address targeting the somewhere.com domain, which they thought was harmless. I know a former owner of that domain, who eventually sold it to one of the anti-spam companies, because it receives a never ending stream. While I've not yet encountered otherplace as a TLD parallel to com, org, etc., in today's world where anyone willing to spend the money can create their own -- http://otherplace/ might well become a live URI at some point.

I do not think it appropriate to create issues on issues on issues, raising things like the example TLDs externally to the issues where they surface, in order to keep the thread of each issue focused purely on the initial issue raised there. Among other reasons, I believe this because those internal issues tend to already have been raised and discussed and resulted in things like the example TLD RFC; at the least, I might post a comment that linked directly to that RFC and say no more ... but that seems to me significantly more critical and less constructive.

Finally, I don't believe I've ever said nor even implied that someone's contribution was unwelcome, no matter the number of issues I may have flagged therein. I believe that all of these projects are team efforts, and that all contributions are valuable. If I've inadvertently made someone feel unwelcome, please provide a link to the instance, in public or private, and I'll certainly try to straighten that out!

ewingson commented 2 years ago

@TallTed @jeff-zucker in this particular case it would seem appropriate to my (half-layman, half-pro) eyes to use the correct term without too much effort. because of the readability and the pedagogic effect of at first sight simple examples I would suggest the usage of speaking TLDs (similar to the usage of speaking variables in code).