valpackett
commented
4 years ago Looks like you should use the master branch of the build scripts here, not the 19.09
Closed agrajag9 closed 3 years ago
valpackett
commented
4 years ago Looks like you should use the master branch of the build scripts here, not the 19.09
agrajag9
commented
4 years ago You might think so, except that clones edk2-platforms from the CodeAura qoriq repos which have basically none of the work done by SolidRun :(
Compare this patch from SolidRun to add device aliases: https://github.com/SolidRun/edk2-platforms/commit/0d216c07acc4fa275328ad9c15c0f51a56241b52
With this version in CodeAura: https://source.codeaurora.org/external/qoriq/qoriq-components/edk2-platforms/tree/Silicon/NXP/LX2160A/Include/DeviceTreeInclude/fsl-lx2160a.dtsi?h=master
Also the runme.sh in master doesn't clone tianocore/edk2 or tianocore/edk2-non-osi, the former of which is necessary for UEFI compilation.
Aside, the master runme.sh also basically has no code path that leads to UEFI compilation at all as it's part of a conditional that will never be true. At line 94:
QORIQ_COMPONENTS="u-boot atf rcw restool mc-utils linux dpdk"
for i in $QORIQ_COMPONENTS; do
...<truncated>...
if [ "x$i" == "xuefi" ]; then
cd $ROOTDIR/build/uefi/
git clone https://source.codeaurora.org/external/qoriq/qoriq-components/edk2-platforms
cd edk2-platforms
git checkout -b $RELEASE refs/tags/$RELEASE
patch -p1 < $ROOTDIR/patches/edk2-platforms/*.diff
git am --keep-cr $ROOTDIR/patches/edk2-platforms/*.patch
fi@myfreeweb The plot thickens: this entire LSDK-19.09-sr-uefi branch is now missing...
$ git clone https://github.com/SolidRun/lx2160a_build
Cloning into 'lx2160a_build'...
remote: Enumerating objects: 81, done.
remote: Counting objects: 100% (81/81), done.
remote: Compressing objects: 100% (65/65), done.
remote: Total 308 (delta 30), reused 60 (delta 14), pack-reused 227
Receiving objects: 100% (308/308), 11.09 MiB | 15.82 MiB/s, done.
Resolving deltas: 100% (118/118), done.
$ cd lx2160a_build/
$ git branch -a
* master
remotes/origin/HEAD -> origin/master
remotes/origin/LSDK-19.06-sr
remotes/origin/LSDK-19.09-sr
remotes/origin/masterCan somebody from SolidRun comment? I know there's work to get the new LSDK release working in the master branch, but deleting the only reliable UEFI branch seems a little odd...
Per this discussion on the freebsd-arm list: https://lists.freebsd.org/pipermail/freebsd-arm/2020-May/021661.html
Right now the edk2-platforms submodule is pinned to commit d65b0a8432334df2905ebe30b5fa7b7996121972, but this several useful commits behind now and as such ACPI is only semi-functioning on UEFI.
Would it be possible to move the submodule forward to at least 97e6b0a36a925f57568d8e411666cfb5034aa38b?