search

SolidSoils / Arduino

C# .NET - Arduino library supporting simultaneous serial ASCII, Firmata and I2C communication
https://solidsoils.github.io/Arduino/index.html
BSD 2-Clause "Simplified" License
200 stars 61 forks source link

Migrate to netstandard2.0 #35

Closed AngelMunoz closed 3 years ago

AngelMunoz commented 4 years ago

Hey I'm getting an Arduino soon and I'm pretty much new to the Arduino space, but I was looking for options on .net it seems so far that you have the best-supported library so far even Microsoft doesn't seem to be doing much about Arduino, (Raspberry PI is another story though)

I wanted to see if you are interested in migrating from full .net framework to netstandard2.0 I gave myself a try at doing it on my fork primarily the library and the unit tests project (I did try to update version on the other projects, but no luck so far building the Monitor) and the projects build fine I ran the tests and it seems there are only 7 tests failing from the testing project, I can't get the Integrations test to run

but my guess is that I don't have (yet) an Arduino connected to my PC and that's making the tests fail Test Run

I know there's some talk about something similar in #30 perhaps we could coordinate if you are interested let me know 😁 you can give my fork a test run and see if it's worth the effort

Edit: Basically it's just removing a bunch of stuff from the *.csproj files here's the commit https://github.com/AngelMunoz/Arduino/commit/503ce689b73a627f2f559d072a11f89ef5019f73 I didn't try to migrate the other two projects to net core since those seem to be desktop gui apps/tests, and not sure exactly what is the exactly process to migrate those kinds of projects.

SolidSoils commented 4 years ago

It has been a long time ago I committed my last update to this project and I feel it is time to add some updates. .Net Standard would be a nice target. Also want to implement some other features, e.g. TC/IP support is high on my list.

Don't bother much about the Monitor project. Years ago I intended to create a demo WPF program, but did not took it further.

AngelMunoz commented 4 years ago

Don't bother much about the Monitor project. Years ago I intended to create a demo WPF program, but did not took it further.

Sounds good! I'll take it away then.

I managed to build the docs as well

docs

as soon as I get my Arduino I'll try to run the tests again, so far everything builds and tests run fine (the ones that don't seem to require an Arduino to be able to be tested)

jeroenwalter commented 4 years ago

You may try my .net core 3.0 fork. https://github.com/jeroenwalter/Arduino/tree/netcore30 I haven't touched it in a while, but I'm now revisiting it, as I now need to use it on a Raspberry Pi.

SolidSoils commented 3 years ago

Library has been upgraded to .NET Standard 2.0.