search

Solidity-Jobs / S-Token

This is a Security Token!
0 stars 1 forks source link

SJSC01 – Unsecure feeReceiver Change (Low) #7

Closed Reg0x closed 3 years ago

Reg0x commented 3 years ago

The modification process of a feeReceiver is a delicate process, since the funding of the project or its continuity can be at risk, for this reason it is recommended to adjust the modification logic, to a logic that allows to verify that the new address is in fact valid and does exist.

Following, it would be convenient to consider using the AccessControl to simplify and unify these types of modifications and to avoid human errors that may later occur. For example, a missing zero address validation was detected in the constructor, which would make it impossible to change the feeReceiver address in the future.

Reg0x commented 3 years ago

https://github.com/Solidity-Jobs/S-Token/blob/44363c599da7b19ee922be33816edbeacffa2139/CRPNT.sol#L71

Reg0x commented 3 years ago

https://github.com/Solidity-Jobs/S-Token/blob/44363c599da7b19ee922be33816edbeacffa2139/CRPNT.sol#L22

solidityjobsdev commented 3 years ago

Solved in #19