search

Sollace / Psychedelicraft

Drug experience mod for Minecraft
MIT License
17 stars 7 forks source link

Localized the few words appearing in the distorted chat messages #25

Closed Blayung closed 10 months ago

Sollace commented 1 year ago

It's a good idea, I'm just not sure about how it's being down here. I think it could be done better, performance-wise.

Blayung commented 1 year ago

I don't know man, it looks fine to me. How would you want to improve it? You could make the translation keys' ranges static, but that's going for a shitty compromise, where performance isn't really that bad.

Sollace commented 1 year ago

I would just avoid creating a list of all of them, considering all of them are the same string + i. You only really need to count how many there are to pass to the random.

Blayung commented 12 months ago

Oh, yeah that's something I haven't thought about.

Blayung commented 12 months ago

I've just pushed a correction, take a look at it.

Blayung commented 10 months ago

Are you gonna merge it?

Sollace commented 10 months ago

Yeah, yeah. I still have to review it. I'll merge when I get back to working on this.

Sollace commented 10 months ago

Merged. Thanks!