search

Sollace / Unicopia

The pony powers mod to power in your pony pony pony
https://modrinth.com/mod/unicopia
56 stars 22 forks source link

black holes need a size cap #326

Closed Fauli1221 closed 4 months ago

Fauli1221 commented 5 months ago

2024-04-07_01 06 37 2024-04-07_01 06 34 2024-04-07_01 06 07 2024-04-07_01 06 03

LotusCookie commented 5 months ago

image

Seems to mostly be a problem if you put the spell underground, but.. Yeah, if it gets to the size where it can break blocks, it will quickly grow to world-destroying size.

It seems that bedrock and barriers are actually safe from the black hole, but some things like gravestones can get destroyed.

Fauli1221 commented 5 months ago

For the last thing lotus mentioned a config with an array and the possibility to decide what blocks it can break would be quiet useful for modpack makers and maybe even make it possible to configure the max size so that if someone wanted they could restore the current behavior by setting that to like -1 or something

Sollace commented 5 months ago

This is done/fixed. I went and rewrote the logic for the black holes somewhat to no longer share code with the shield which fixes a whole swath of issues.

To summarise:

  1. It will now break blocks in chunks rather than all at once
  2. The diameter is capped to between 1 and 25 blocks (configurable by the maxDarkVortexSize gamerule)
  3. Blocks in the unicopia:catapult_immune are excluded from being affected by black holes now too (add your tombstones to that)
  4. The black hole now creates an explosion when it can no longer sustain itself from it's creator's mana (previously would silently dissapear)
  5. Black holes now explode when they collide with each other (paradoxially, it's now safer to have two black holes than one)
  6. Black hole's growth rate has been made logarithmic with the function diameter = (1 - (1/(1 + mass))) * maxRadius
  7. Changed various particle and rendering effects to make it look better
Fauli1221 commented 5 months ago

Is it possible to uncap the black hole diameter limit while this would not be useful in survival it could be funny if a creative test world also is the diameter measured in meters I assume it is and if so could you increase the max to 100 Also what is the default

Sollace commented 5 months ago

Is it possible to uncap the black hole diameter limit while this would not be useful in survival it could be funny if a creative test world also is the diameter measured in meters I assume it is and if so could you increase the max to 100 Also what is the default

The default is 20, and chose 25 as the max-max because the game becomes unplayable above that.