search

SollmoStudio / beyond

Beyond: The Scalable Game Server Framework
http://www.beyondframework.com
Apache License 2.0
25 stars 9 forks source link

Why are `response.js` and `ScriptableResponse` separated? #159

Closed hatashiro closed 9 years ago

hatashiro commented 9 years ago

Currently, exports.Response in response.js and ScriptableResponse are different objects, despite the fact that for other modules(but for request.js) a JavaScript source in the lib directory just redirects exports to the target Scala module. For example, uuid.js is just like this: module.exports = UUID;.

I can't see any reason to separate them. It makes fixing them complicated, as both of them need to be changed. For example, like this: #157.

If possible, I'd bother fixing this.

ghost commented 9 years ago

@sgkim126

hatashiro commented 9 years ago

Moved to #161. Closed.