search

SollmoStudio / beyond

Beyond: The Scalable Game Server Framework
http://www.beyondframework.com
Apache License 2.0
25 stars 9 forks source link

Seperate module source provider for library and plugin code. #174

Closed sgkim126 closed 9 years ago

sgkim126 commented 9 years ago

Currently, both library and plugin uses UrlModuleSourceProvider. But assets are packaged to jar on deployment and UrlModuleSourceProvider cannot read source from jar. So this patch makes Beyond uses AssetsModuleSourceProvider for library. But plugin code still should read with UrlModuleSourceProvider.

To implement it this patch makes BeyondGlobal takes ModuleSourceProvider as an argument. This provider will be used for library code.

ghost commented 9 years ago

Good!

sgkim126 commented 9 years ago

I added the last commit.

hatashiro commented 9 years ago

LGTM but for the FIXME comment.

sgkim126 commented 9 years ago

I added FIXME comment

hatashiro commented 9 years ago

LGTM