SollmoStudio / beyond

Beyond: The Scalable Game Server Framework
http://www.beyondframework.com
Apache License 2.0
25 stars 9 forks source link

Some suggestions to enhance JS part. #194

Closed hatashiro closed 9 years ago

hatashiro commented 9 years ago

Any idea guys? @sgkim126 @kimchoco @murmur76

sgkim126 commented 9 years ago

I'm worrying about using npm. Does npm work well with Rhino?

sgkim126 commented 9 years ago

And what's the reason for using Browserify(or Webpack)? As I know browserify makes easy to use modules on the browser. And I don't get why we need it.

sgkim126 commented 9 years ago

I prefer 2 spaces for indent. But I'm not heavy user of JavaScript. So If you prefer the others, I'll follow your opinion.

sgkim126 commented 9 years ago

Could you explain more about ESLint? What's the cons of the ESLint?

hatashiro commented 9 years ago
  1. We're already using Gulp in our project. NPM will be used with Node.
  2. Browserify + NPM provides CommonJS module system, so it may be familiar to Node developers as well. Also it can separate frontend libraries from the project. I think it's not good idea to contain third-party static files like this. However, this is kinda a big change, so wouldn't be so necessary. Just suggestion.
  3. +1 for 2 spaces for indent. Any idea, @kimchoco?
  4. ESLint has more rules and settings. For example, ESLint can be set to find out a missing space after a function keyword like function() which should be function (), however JSHint can't.
sgkim126 commented 9 years ago

Okay, all of your proposal looks good to me

hatashiro commented 9 years ago

Using ESLint and unify tab sizes have been applied. I'd close the issue, as the front-end fix is not essential.