search

SollmoStudio / beyond

Beyond: The Scalable Game Server Framework
http://www.beyondframework.com
Apache License 2.0
25 stars 9 forks source link

Ignore scalastyle null checker explicitly when passing null to Rhino. #205

Closed sgkim126 closed 9 years ago

sgkim126 commented 9 years ago

No way to avoid using null for these cases, because Rhino is Java library and they needs null as an argument.

This is a part of #202

hatashiro commented 9 years ago

I'm a little bit worried to add // scalastyle:ignore null everywhere. How about implement something like Null with which is actually null and use it instead? Then we can just put one // scalastyle:ignore null in the definition of Null.

sgkim126 commented 9 years ago

I don't agree with you. If we start to define Null and use it, we have no way to check using null.

hatashiro commented 9 years ago

Btw, can't we just turn off only null rule if it's not a big deal? Putting the comments everywhere seems kinda too much.

sgkim126 commented 9 years ago

Only you and I(or someone who is more accustomed with Scala than Java) will develop it, we can turn of null checker. But IMO we should turn on null check to prepare that some day someone who is not familiar with Scala starts to contribute here.

Actually I want to make null checker make error instead of warning.

sgkim126 commented 9 years ago

It's not weird for me that turn off null checker only when using java library.