Solo5 / solo5

A sandboxed execution environment for unikernels
ISC License
892 stars 138 forks source link

checkpatch.pl doesn't like being run from the solo5 source tree #142

Closed ijc closed 7 years ago

ijc commented 7 years ago

README.md says:

The coding style for this project is "Linux with 4 spaces instead of tabs". The modified checkpatch.pl script helps give hints about what violates this style.

but:

solo5$ git format-patch --stdout HEAD~1 | ./checkpatch.pl -
Must be run from the top-level dir. of a kernel tree

It is checking for various files, the majority of which do not exist:

sub top_of_kernel_tree {
        my ($root) = @_;

        my @tree_check = (
                "COPYING", "CREDITS", "Kbuild", "MAINTAINERS", "Makefile",
                "README", "Documentation", "arch", "include", "drivers",
                "fs", "init", "ipc", "kernel", "lib", "scripts",
        );

        foreach my $check (@tree_check) {
                if (! -e $root . '/' . $check) {
                        return 0;
                }
        }
        return 1;
}
mato commented 7 years ago

checkpatch.pl has been removed as part of #153 so I'm closing this.