Solo5 / solo5

A sandboxed execution environment for unikernels
ISC License
883 stars 136 forks source link

Fix noexec test #547

Closed greydot closed 1 year ago

greydot commented 1 year ago

Since some point recently, this test fails (as it is expected to) but with a different error message. This PR adds a case for this.

Alternatively, I propose removing the error message check altogether, since it is too fragile and might be affected - among other things - by locale settings.

ehmry commented 1 year ago

This test might be fine for the BSDs but I don't think it can be reliable for Linux. The error comes from userspace and Linux doesn't have one.

greydot commented 1 year ago

The error comes from userspace and Linux doesn't have one.

What do you mean? This error comes from glibc. They simply changed the error message for some reason.

ehmry commented 1 year ago

Right, so the test must check which version of Glibc is present rather than if the host is Linux.

greydot commented 1 year ago

I don't think this is feasible. We could either include all variants -- so far there seem to be only two -- or just rely on the exit code. I'd vote for the latter.

dinosaure commented 1 year ago

Thanks!