Sology / maily_herald

Advanced email processing solution for Ruby on Rails applications
http://mailyherald.org
Other
579 stars 59 forks source link

ng: ActionMailer is called statically #46

Open jaco-terbraak opened 4 years ago

jaco-terbraak commented 4 years ago

When a ActionMailer is defined, it should be instantiated before being called. Instead it is called statically, resulting in the following error:

---
:msg: |-
  protected method `process' called for #<HelloMailer:0x00007fc2edb0e368>

  $HOME/.rvm/gems/ruby-2.5.3/gems/actionmailer-6.0.3.2/lib/action_mailer/message_delivery.rb:124:in `block in processed_mailer'
  $HOME/.rvm/gems/ruby-2.5.3/gems/actionmailer-6.0.3.2/lib/action_mailer/message_delivery.rb:123:in `tap'
  $HOME/.rvm/gems/ruby-2.5.3/gems/actionmailer-6.0.3.2/lib/action_mailer/message_delivery.rb:123:in `processed_mailer'
  $HOME/.rvm/gems/ruby-2.5.3/gems/actionmailer-6.0.3.2/lib/action_mailer/message_delivery.rb:30:in `__getobj__'
  $HOME/.rvm/rubies/ruby-2.5.3/lib/ruby/2.5.0/delegate.rb:80:in `method_missing'
  $HOME/.rvm/gems/ruby-2.5.3/bundler/gems/maily_herald-bd3ec31974c0/app/models/maily_herald/mailing.rb:194:in `deliver'
  $HOME/.rvm/gems/ruby-2.5.3/bundler/gems/maily_herald-bd3ec31974c0/app/models/maily_herald/one_time_mailing.rb:19:in `block in run'
  $HOME/.rvm/gems/ruby-2.5.3/gems/activerecord-6.0.3.2/lib/active_record/relation/delegation.rb:87:in `each'
  $HOME/.rvm/gems/ruby-2.5.3/gems/activerecord-6.0.3.2/lib/active_record/relation/delegation.rb:87:in `each'
  $HOME/.rvm/gems/ruby-2.5.3/bundler/gems/maily_herald-bd3ec31974c0/app/models/maily_herald/one_time_mailing.rb:17:in `collect'
  $HOME/.rvm/gems/ruby-2.5.3/bundler/gems/maily_herald-bd3ec31974c0/app/models/maily_herald/one_time_mailing.rb:17:in `run'
  $HOME/.rvm/gems/ruby-2.5.3/bundler/gems/maily_herald-bd3ec31974c0/lib/maily_herald/manager.rb:25:in `block in run_all'
  $HOME/.rvm/gems/ruby-2.5.3/gems/activerecord-6.0.3.2/lib/active_record/relation/delegation.rb:87:in `each'
  $HOME/.rvm/gems/ruby-2.5.3/gems/activerecord-6.0.3.2/lib/active_record/relation/delegation.rb:87:in `each'
  $HOME/.rvm/gems/ruby-2.5.3/bundler/gems/maily_herald-bd3ec31974c0/lib/maily_herald/manager.rb:25:in `run_all'
  $HOME/.rvm/gems/ruby-2.5.3/bundler/gems/maily_herald-bd3ec31974c0/lib/maily_herald.rb:31:in `perform'
  $HOME/.rvm/gems/ruby-2.5.3/gems/sidekiq-6.1.1/lib/sidekiq/processor.rb:196:in `execute_job'
  $HOME/.rvm/gems/ruby-2.5.3/gems/sidekiq-6.1.1/lib/sidekiq/processor.rb:164:in `block (2 levels) in process'
  $HOME/.rvm/gems/ruby-2.5.3/gems/sidekiq-6.1.1/lib/sidekiq/middleware/chain.rb:138:in `block in invoke'
  $HOME/.rvm/gems/ruby-2.5.3/gems/rollbar-2.26.0/lib/rollbar/plugins/sidekiq/plugin.rb:11:in `call'
  $HOME/.rvm/gems/ruby-2.5.3/gems/sidekiq-6.1.1/lib/sidekiq/middleware/chain.rb:140:in `block in invoke'
  $HOME/.rvm/gems/ruby-2.5.3/gems/sidekiq-6.1.1/lib/sidekiq/middleware/chain.rb:143:in `invoke'
  $HOME/.rvm/gems/ruby-2.5.3/gems/sidekiq-6.1.1/lib/sidekiq/processor.rb:163:in `block in process'
  $HOME/.rvm/gems/ruby-2.5.3/gems/sidekiq-6.1.1/lib/sidekiq/processor.rb:136:in `block (6 levels) in dispatch'
  $HOME/.rvm/gems/ruby-2.5.3/gems/sidekiq-6.1.1/lib/sidekiq/job_retry.rb:111:in `local'
  $HOME/.rvm/gems/ruby-2.5.3/gems/sidekiq-6.1.1/lib/sidekiq/processor.rb:135:in `block (5 levels) in dispatch'
  $HOME/.rvm/gems/ruby-2.5.3/gems/sidekiq-6.1.1/lib/sidekiq/rails.rb:14:in `block in call'
  $HOME/.rvm/gems/ruby-2.5.3/gems/activesupport-6.0.3.2/lib/active_support/execution_wrapper.rb:88:in `wrap'
  $HOME/.rvm/gems/ruby-2.5.3/gems/activesupport-6.0.3.2/lib/active_support/reloader.rb:72:in `block in wrap'
  $HOME/.rvm/gems/ruby-2.5.3/gems/activesupport-6.0.3.2/lib/active_support/execution_wrapper.rb:88:in `wrap'
  $HOME/.rvm/gems/ruby-2.5.3/gems/activesupport-6.0.3.2/lib/active_support/reloader.rb:71:in `wrap'
  $HOME/.rvm/gems/ruby-2.5.3/gems/sidekiq-6.1.1/lib/sidekiq/rails.rb:13:in `call'
  $HOME/.rvm/gems/ruby-2.5.3/gems/sidekiq-6.1.1/lib/sidekiq/processor.rb:131:in `block (4 levels) in dispatch'
  $HOME/.rvm/gems/ruby-2.5.3/gems/sidekiq-6.1.1/lib/sidekiq/processor.rb:257:in `stats'
  $HOME/.rvm/gems/ruby-2.5.3/gems/sidekiq-6.1.1/lib/sidekiq/processor.rb:126:in `block (3 levels) in dispatch'
  $HOME/.rvm/gems/ruby-2.5.3/gems/sidekiq-6.1.1/lib/sidekiq/job_logger.rb:13:in `call'
  $HOME/.rvm/gems/ruby-2.5.3/gems/sidekiq-6.1.1/lib/sidekiq/processor.rb:125:in `block (2 levels) in dispatch'
  $HOME/.rvm/gems/ruby-2.5.3/gems/sidekiq-6.1.1/lib/sidekiq/job_retry.rb:78:in `global'
  $HOME/.rvm/gems/ruby-2.5.3/gems/sidekiq-6.1.1/lib/sidekiq/processor.rb:124:in `block in dispatch'
  $HOME/.rvm/gems/ruby-2.5.3/gems/sidekiq-6.1.1/lib/sidekiq/logger.rb:10:in `with'
  $HOME/.rvm/gems/ruby-2.5.3/gems/sidekiq-6.1.1/lib/sidekiq/job_logger.rb:33:in `prepare'
  $HOME/.rvm/gems/ruby-2.5.3/gems/sidekiq-6.1.1/lib/sidekiq/processor.rb:123:in `dispatch'
  $HOME/.rvm/gems/ruby-2.5.3/gems/sidekiq-6.1.1/lib/sidekiq/processor.rb:162:in `process'
  $HOME/.rvm/gems/ruby-2.5.3/gems/sidekiq-6.1.1/lib/sidekiq/processor.rb:78:in `process_one'
  $HOME/.rvm/gems/ruby-2.5.3/gems/sidekiq-6.1.1/lib/sidekiq/processor.rb:68:in `run'
  $HOME/.rvm/gems/ruby-2.5.3/gems/sidekiq-6.1.1/lib/sidekiq/util.rb:15:in `watchdog'
  $HOME/.rvm/gems/ruby-2.5.3/gems/sidekiq-6.1.1/lib/sidekiq/util.rb:24:in `block in safe_thread'