Update README regarding JS dependency

Sology / smart_listing

Ruby on Rails data listing gem with built-in sorting, filtering and in-place editing.

http://showcase.sology.eu/smart_listing

MIT License

478 stars 138 forks source link

Update README regarding JS dependency #145

Open fwolfst opened 6 years ago

fwolfst commented 6 years ago

Cool stuff. As far as I see from the showcase page most stuff (sorting, filtering, pagination) is totally usable without JavaScript. As I am in search for a solution that also works without JavaScript it would be nice if that is reflected in the README. Or am I mistaken? There might still be some minor issues (i.e. I found in-place-editing to surprisingly not working ;) ), but there a simple enabling of the edit-button only if JS is enabled shouldnt be too problematic.

FiloSpaTeam commented 5 years ago

I confirm that in-place-editing is not working but is a problem with Config initialization if you change hidden class :+1: For example for Bootstrap 4 you need to use d-none and not hidden. I initialized d-none but when merged you have hidden class in your JS configuration.