smart_listing.paginate broke with Ruby 3.1.1

Sology / smart_listing

Ruby on Rails data listing gem with built-in sorting, filtering and in-place editing.

http://showcase.sology.eu/smart_listing

MIT License

478 stars 137 forks source link

Open xungngo opened 2 years ago

xungngo commented 2 years ago

<%= smart_listing.paginate %> Resulted in wrong number of arguments (given 2, expected 1)

TRACE: [kaminari-core (1.2.2) lib/kaminari/helpers/helper_methods.rb:116:in `paginate']

[smart_listing (1.2.3) app/helpers/smart_listing/helper.rb:49:in `paginate']

dannyvanhoof commented 2 years ago

looks like since ruby 3, a ** is needed in front of the options dictionary:

@template.paginate @smart_listing.collection, **{:remote => @smart_l...

moirazz commented 1 year ago

any update on this issue? I'm running into the same thing

xungngo commented 1 year ago

What dannyvanhoof said above BUT I would abandon this kind of gems.