SolomonDefi / solomon-monorepo

Monorepo containing core Solomon apps, services, libraries, and deploy config.
6 stars 3 forks source link

Docker cleanup #124

Closed kelvin-wong closed 3 years ago

kelvin-wong commented 3 years ago

close #109

solomondefi-dev commented 3 years ago

@kelvin-wong Is this supposed to close #125 instead of #109?

kelvin-wong commented 3 years ago

@kelvin-wong Is this supposed to close #125 instead of #109?

@solomondefi-dev no, this fixed problem 1 and 2 only. Problem 3 is more complicated.

solomondefi-dev commented 3 years ago

Ah, nevermind, I misread the messages there. I am checking this now.

solomondefi-dev commented 3 years ago

Whoops, I forgot the reason we include g++ and make in the blockchain-watcher build. It's because on mac M1, the @parcel/watcher package introduced in 12.10.0 fails to find a binary for something (node-gyp?), and needs to install whatever is missing:

#19 37.32 .../node_modules/@parcel/watcher install$ node-gyp-build
#19 37.62 .../node_modules/@parcel/watcher install: gyp info it worked if it ends with ok
#19 37.62 .../node_modules/@parcel/watcher install: gyp info using node-gyp@8.3.0
#19 37.62 .../node_modules/@parcel/watcher install: gyp info using node@14.18.1 | linux | arm64
#19 37.80 .../node_modules/@parcel/watcher install: gyp info find Python using Python version 3.9.5 found at "/usr/bin/python3"
#19 37.96 .../node_modules/@parcel/watcher install: gyp http GET https://nodejs.org/download/release/v14.18.1/node-v14.18.1-headers.tar.gz
#19 38.16 .../node_modules/@parcel/watcher install: gyp http 200 https://nodejs.org/download/release/v14.18.1/node-v14.18.1-headers.tar.gz
#19 38.57 .../node_modules/@parcel/watcher install: gyp http GET https://nodejs.org/download/release/v14.18.1/SHASUMS256.txt
#19 38.59 .../node_modules/@parcel/watcher install: gyp http 200 https://nodejs.org/download/release/v14.18.1/SHASUMS256.txt
#19 38.61 .../node_modules/@parcel/watcher install: gyp info spawn /usr/bin/python3
#19 38.61 .../node_modules/@parcel/watcher install: gyp info spawn args [
#19 38.61 .../node_modules/@parcel/watcher install: gyp info spawn args   '/usr/pnpm-global/5/node_modules/.pnpm/pnpm@6.19.0/node_modules/pnpm/dist/node_modules/node-gyp/gyp/gyp_main.py',
#19 38.61 .../node_modules/@parcel/watcher install: gyp info spawn args   'binding.gyp',
#19 38.61 .../node_modules/@parcel/watcher install: gyp info spawn args   '-f',
#19 38.61 .../node_modules/@parcel/watcher install: gyp info spawn args   'make',
#19 38.61 .../node_modules/@parcel/watcher install: gyp info spawn args   '-I',
#19 38.61 .../node_modules/@parcel/watcher install: gyp info spawn args   '/usr/src/node_modules/.pnpm/@parcel+watcher@2.0.0-alpha.11/node_modules/@parcel/watcher/build/config.gypi',
#19 38.61 .../node_modules/@parcel/watcher install: gyp info spawn args   '-I',
#19 38.61 .../node_modules/@parcel/watcher install: gyp info spawn args   '/usr/pnpm-global/5/node_modules/.pnpm/pnpm@6.19.0/node_modules/pnpm/dist/node_modules/node-gyp/addon.gypi',
#19 38.61 .../node_modules/@parcel/watcher install: gyp info spawn args   '-I',
#19 38.61 .../node_modules/@parcel/watcher install: gyp info spawn args   '/root/.cache/node-gyp/14.18.1/include/node/common.gypi',
#19 38.61 .../node_modules/@parcel/watcher install: gyp info spawn args   '-Dlibrary=shared_library',
#19 38.61 .../node_modules/@parcel/watcher install: gyp info spawn args   '-Dvisibility=default',
#19 38.61 .../node_modules/@parcel/watcher install: gyp info spawn args   '-Dnode_root_dir=/root/.cache/node-gyp/14.18.1',
#19 38.61 .../node_modules/@parcel/watcher install: gyp info spawn args   '-Dnode_gyp_dir=/usr/pnpm-global/5/node_modules/.pnpm/pnpm@6.19.0/node_modules/pnpm/dist/node_modules/node-gyp',
#19 38.61 .../node_modules/@parcel/watcher install: gyp info spawn args   '-Dnode_lib_file=/root/.cache/node-gyp/14.18.1/<(target_arch)/node.lib',
#19 38.61 .../node_modules/@parcel/watcher install: gyp info spawn args   '-Dmodule_root_dir=/usr/src/node_modules/.pnpm/@parcel+watcher@2.0.0-alpha.11/node_modules/@parcel/watcher',
#19 38.61 .../node_modules/@parcel/watcher install: gyp info spawn args   '-Dnode_engine=v8',
#19 38.61 .../node_modules/@parcel/watcher install: gyp info spawn args   '--depth=.',
#19 38.61 .../node_modules/@parcel/watcher install: gyp info spawn args   '--no-parallel',
#19 38.61 .../node_modules/@parcel/watcher install: gyp info spawn args   '--generator-output',
#19 38.61 .../node_modules/@parcel/watcher install: gyp info spawn args   'build',
#19 38.61 .../node_modules/@parcel/watcher install: gyp info spawn args   '-Goutput_dir=.'
#19 38.61 .../node_modules/@parcel/watcher install: gyp info spawn args ]
#19 38.94 .../node_modules/@parcel/watcher install: gyp ERR! build error
#19 38.94 .../node_modules/@parcel/watcher install: gyp ERR! stack Error: not found: make
#19 38.94 .../node_modules/@parcel/watcher install: gyp ERR! stack     at getNotFoundError (/usr/pnpm-global/5/node_modules/.pnpm/pnpm@6.19.0/node_modules/pnpm/dist/node_modules/which/which.js:10:17)
#19 38.94 .../node_modules/@parcel/watcher install: gyp ERR! stack     at /usr/pnpm-global/5/node_modules/.pnpm/pnpm@6.19.0/node_modules/pnpm/dist/node_modules/which/which.js:57:18
#19 38.94 .../node_modules/@parcel/watcher install: gyp ERR! stack     at new Promise (<anonymous>)
#19 38.94 .../node_modules/@parcel/watcher install: gyp ERR! stack     at step (/usr/pnpm-global/5/node_modules/.pnpm/pnpm@6.19.0/node_modules/pnpm/dist/node_modules/which/which.js:54:21)
#19 38.94 .../node_modules/@parcel/watcher install: gyp ERR! stack     at /usr/pnpm-global/5/node_modules/.pnpm/pnpm@6.19.0/node_modules/pnpm/dist/node_modules/which/which.js:71:22
#19 38.94 .../node_modules/@parcel/watcher install: gyp ERR! stack     at new Promise (<anonymous>)
#19 38.94 .../node_modules/@parcel/watcher install: gyp ERR! stack     at subStep (/usr/pnpm-global/5/node_modules/.pnpm/pnpm@6.19.0/node_modules/pnpm/dist/node_modules/which/which.js:69:33)
#19 38.94 .../node_modules/@parcel/watcher install: gyp ERR! stack     at /usr/pnpm-global/5/node_modules/.pnpm/pnpm@6.19.0/node_modules/pnpm/dist/node_modules/which/which.js:80:22
#19 38.94 .../node_modules/@parcel/watcher install: gyp ERR! stack     at /usr/pnpm-global/5/node_modules/.pnpm/pnpm@6.19.0/node_modules/pnpm/dist/node_modules/isexe/index.js:42:5
#19 38.94 .../node_modules/@parcel/watcher install: gyp ERR! stack     at /usr/pnpm-global/5/node_modules/.pnpm/pnpm@6.19.0/node_modules/pnpm/dist/node_modules/isexe/mode.js:8:5
#19 38.94 .../node_modules/@parcel/watcher install: gyp ERR! stack     at FSReqCallback.oncomplete (fs.js:191:21)
#19 38.94 .../node_modules/@parcel/watcher install: gyp ERR! System Linux 5.10.47-linuxkit
#19 38.94 .../node_modules/@parcel/watcher install: gyp ERR! command "/usr/bin/node" "/usr/pnpm-global/5/node_modules/.pnpm/pnpm@6.19.0/node_modules/pnpm/dist/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
#19 38.94 .../node_modules/@parcel/watcher install: gyp ERR! cwd /usr/src/node_modules/.pnpm/@parcel+watcher@2.0.0-alpha.11/node_modules/@parcel/watcher
#19 38.94 .../node_modules/@parcel/watcher install: gyp ERR! node -v v14.18.1
#19 38.94 .../node_modules/@parcel/watcher install: gyp ERR! node-gyp -v v8.3.0
#19 38.94 .../node_modules/@parcel/watcher install: gyp ERR! not ok
#19 38.95 .../node_modules/@parcel/watcher install: Failed
#19 38.96  ELIFECYCLE  Command failed with exit code 1.
#19 ERROR: executor failed running [/bin/sh -c pnpm install]: exit code: 1

I'm going to merge this and try see if it's resolved by updating to Nx 13, which may have a newer version of @parcel/watcher.

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 1.2.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: