search

SolomonDefi / solomon-monorepo

Monorepo containing core Solomon apps, services, libraries, and deploy config.
6 stars 4 forks source link

watcher webhook #131

Closed apolkingg8 closed 2 years ago

apolkingg8 commented 2 years ago

Pin @typechain/ethers-v5 version to 7.x.x. Ref: #139

apolkingg8 commented 2 years ago

I think there are some tests that need to be completed, but let's merge it first to avoid blocking others' work.

solomondefi-dev commented 2 years ago

Overall this looks fine to me, you can merge any time. I do prefer that commits are squashed into logical groups, e.g.

💚 [api]: fix CI build #93 07542fc
⬆️ [api]: fix format for Nx 13 #93 2efeb3b
⬆️ [api]: fix CI build #93 99a0dd1

...can be combined

I won't require it here since we need to keep moving forward, but it's a general recommendation for keeping the history clean.

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 1.3.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: