Project E2E initialize - Githubissues

SolomonDefi / solomon-monorepo

Monorepo containing core Solomon apps, services, libraries, and deploy config.

6 stars 4 forks source link

Project E2E initialize #161

Closed apolkingg8 closed 2 years ago

apolkingg8 commented 2 years ago

Fork from #115

Init e2e testing environment.
- Run blockchain node, and deploy contracts
Run against full skaffold environment
Implement basic dispute test that shows interaction between all apps
Integrate into CI (push this to another issue if too difficult)
Simulate server up / down quickly and check the issue about duplicate / missing events (maybe another issue)

Consider repurposing the existing blockchain watcher e2e app, since we only really need one overall e2e tests. Other tests can exist within individual apps. Updated the issue title to reflect this, and points to 5.

solomondefi-dev commented 2 years ago

It may be difficult to integrate a true e2e into Github CI without involving skaffold. My suggestion is to give it a try, but not spend too much effort on CI if it's difficult. My point vote is based on that.

beefho67 commented 2 years ago

Hi @apolkingg8 , this one is not started yet, right? Do we still plan to integrate it to Github CI in this issue? If not, we can create a separate issue to track it.

apolkingg8 commented 2 years ago

Integrate into CI (push this to another issue if too difficult)

There is a Service containers feature in GitHub action, and I think no other way to run a service in the GH action. That means, we need some new (and duplicate) Dockers to do that. I prefer pending this before we find a better way to integrate it to CI.

beefho67 commented 2 years ago

@solomondefi-dev Per discussion with @apolkingg8 , we need #206 to work in order to wrap up this issue. I will move this issue to blocked/waiting column until #206 is fixed. Meanwhile, there is still something we can do without #206.