SolomonDefi / solomon-monorepo

Monorepo containing core Solomon apps, services, libraries, and deploy config.
6 stars 3 forks source link

Redesign the git hook and generated files #175

Closed apolkingg8 closed 2 years ago

apolkingg8 commented 2 years ago

I think the generated files should not in git, it should be a hard rule. We can add some helpers in git hooks to help developers to avoid missing the generating step.

~Putting the generating scripts into post-commit can cause commit slow but looks like there is no better hook to put them.~

Remove generate scripts from git hooks, motion it in the document and let developers manually do it.

TODO:

@solomondefi-dev please let me know if you have other ideas.

solomondefi-dev commented 2 years ago

Sure, this makes sense to me.

github-actions[bot] commented 2 years ago

:tada: This issue has been resolved in version 1.3.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: