search

SolomonDefi / solomon-monorepo

Monorepo containing core Solomon apps, services, libraries, and deploy config.
6 stars 3 forks source link

Contract enhancements #204

Closed solomondefi-dev closed 2 years ago

solomondefi-dev commented 2 years ago

Close #192, #68, #191

@jtse0 I cherry-picked the new commits from #194 after merging #188. The conflicts were a bit messy, so you'll probably want to take a look at this before we merge.

It's difficult for me to follow some of the tests, but I think we can take a look at things on a case by case basis after merging.

solomondefi-dev commented 2 years ago

Merging now to avoid blocking other PRs

jtse0 commented 2 years ago

Thanks for helping with the merge @solomondefi-dev. I spotted some changes that weren't merged (mainly relating to the events) but I'll take care of those when I get back and you can take another look at everything. I'll also try to update the tests to make them more readable so let me know which parts of the tests you weren't able to follow. Sorry about that on my part. Thanks again!