Closed apolkingg8 closed 2 years ago
@apolkingg8 I had to make some changes to get everything working:
/api/events/<type>
, e.g. /api/events/dispute.preorder.created
)testInit
accepts SlmFactory
directly, instead of calling Connect again. This was causing problems detecting the deployed contractnpm run skaffold:backend
will run API+Contracts without frontend, for example)fetch
is pretty good, but supertest
has a couple of nice features that I think are worth using.@solomondefi-dev Thanks for your work. About supertest
, I don't think it's a better choice because it's an additional wrap. Additional wrap means additional bugs, which is I always try to avoid. It looks like you usually like large and high-level frameworks/libraries, but I'll prefer to use fewer dependencies and design the architecture by myself. Maybe we can discuss and have a deal later, but in this case, I don't think there is a "must" reason to use it and add it directly in a code review.
supertest
is not too high level or complicated, and unlikely to be the source of bugs, it's been stable for over 7 years.
That's not why I introduced it though, there are two reasons for it:
supertest
for consistency.It's great to try to keep dependencies to a minimum - I appreciate that mentality and use it in my own personal projects. In team projects that need to scale in code size, it's not always the best choice.
Close #161
Close #218